Allow edge + vertex options to be passed to #write_to_graphic_file - #41
Merged
monora merged 4 commits intoFeb 6, 2019
Merged
Conversation
Owner
|
Looks good to me. Could you provide an example graph image which we could include in the README to show this feature? I fixed the travis errors. Could you |
lskalkos
force-pushed
the
add-options-to-write-to-graphic-file
branch
from
January 16, 2019 13:40
a2019b4 to
ec346a9
Compare
lskalkos
force-pushed
the
add-options-to-write-to-graphic-file
branch
from
January 16, 2019 13:54
ec346a9 to
2081d8d
Compare
Contributor
Author
|
Hi there, I made a fix to the vertex settings, updated the test, and added an example to the PR description. Take a look and let me know if there is anything else that needs to be done on this. Thanks! |
Owner
|
Thank you, that is fine. I will mention the feature in the README.md and link to the test, which shows its usage. I will then merge the PR and make a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using this library, and I thought it would be nice to be able to pass additional edge and vertex options into the
write_to_graphic_filemethod -- for instance, to add a label for each edge.The idea is that the original default options get passed in, as well as any additional ones under
params['edge']orparams['vertex']. If the setting comes in the form of aProc, then the proc is called on each edge pair or vertex. Otherwise, the setting will apply to all edges and all vertices.Happy to add tests, or do some additional work to get this in.
Example: