Support incremental output in the pager - #3534
Merged
Merged
Conversation
kdeldycke
marked this pull request as draft
May 29, 2026 14:49
This was
linked to
issues
May 29, 2026
kdeldycke
force-pushed
the
fix-pager-streaming-flush
branch
from
May 29, 2026 14:51
a532677 to
399919f
Compare
This was referenced May 29, 2026
kdeldycke
marked this pull request as ready for review
May 29, 2026 14:56
kdeldycke
added
the
help output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple fix that let the pager incrementally output the chunks of text produced by a generator instead of waiting for it to flush automatically.
So in substance, instead of doing write write write write flush, we do write flush write flush write flush....
Closes #3242 and #2542.
Context: stumble upon that quick fix while working on #3533.