add Connection.use_(certificate|privatekey) - #1121
Merged
Merged
Conversation
mhils
force-pushed
the
connection-use-cert
branch
3 times, most recently
from
May 12, 2022 11:39
2cd7a49 to
e05eac4
Compare
mhils
marked this pull request as draft
May 12, 2022 11:52
Member
|
cryptography 38 is out now 😄 |
mhils
force-pushed
the
connection-use-cert
branch
from
September 7, 2022 10:53
e05eac4 to
d3c13ac
Compare
mhils
marked this pull request as ready for review
September 7, 2022 11:42
Member
|
Conflict here due to the new pinning, but we should get this reviewed ASAP 😄 |
Member
Author
|
Conflict fixed! 😃 |
reaperhulk
approved these changes
Sep 16, 2022
|
This PR has not updated the changelog. Changelog for 22.1 still mentions Cryptography 37 as the minimum version. |
23 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(depends on cryptography 38)
Follow-up to pyca/cryptography#7210. :)
I've added comments to point out the duplication between Context and Connection. Let me know if you want those out, happy to adjust to whatever style you prefer.