PyInstaller: add hooks for google.cloud and google.cloud.storage - #2637
Merged
Conversation
htgoebel
suggested changes
Jun 2, 2017
htgoebel
left a comment
htgoebel
left a comment
Member
There was a problem hiding this comment.
Thanks for this pull-request. Please add the copyright header which you can find in any other hook file.
Contributor
Author
|
Hi @htgoebel ! I've added headers to v2. Please take a look. |
htgoebel
approved these changes
Jun 2, 2017
htgoebel
left a comment
htgoebel
left a comment
Member
There was a problem hiding this comment.
Thanks. Strictly speaking, the data should be "2017" only, since the code of this hook was written this year, I assume. Would you mind to change this?
Otherwise this is okay.
Fixes googleapis/google-cloud-python#1187 v2: added copyright headers v3: fixed year
Contributor
Author
|
Sure. Please see v3. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-python#1187