Add support for adjusting Index to Inline - #394

ydah · 2024-04-09T20:20:33Z

No description provided.

yui-knk · 2024-04-13T05:29:02Z

[note]
Some methods on RuleBuilder require parameterizing_rule_resolver for its argumen, e.g. #setup_rules, #has_inline_rules? and #resolve_inline_rules. It might be better to pass parameterizing_rule_resolver for RuleBuilder#initialize by adding helper function to Grammar which calls Grammar::RuleBuilder.new with @parameterizing_rule_resolver
It's not directly related to this PR, so I don't require to change it in this PR.

yui-knk · 2024-04-13T06:19:55Z

@ydah The direction seems good. Could you check the logic of reference overwrite, #394 (comment) ?

ydah · 2024-04-15T14:29:01Z

@yui-knk Thank you for your review! I updated this PR.

ydah · 2024-04-17T14:08:04Z

[note] Some methods on RuleBuilder require parameterizing_rule_resolver for its argumen, e.g. #setup_rules, #has_inline_rules? and #resolve_inline_rules. It might be better to pass parameterizing_rule_resolver for RuleBuilder#initialize by adding helper function to Grammar which calls Grammar::RuleBuilder.new with @parameterizing_rule_resolver It's not directly related to this PR, so I don't require to change it in this PR.

@yui-knk Add refactoring commit: 514e61c

``` ❯ exe/lrama -d sample/calc.y -o calc.c && gcc -Wall calc.c -o calc && ./calc Enter the formula: 1 parse error: syntax error, unexpected NUM [1] 52278 segmentation fault ./calc ```

ydah · 2024-05-17T06:32:30Z

@yui-knk I rebased and fix conflict.

yui-knk · 2024-05-17T06:42:37Z

LGTM!

ydah force-pushed the inline-index branch from e1aacf5 to 926b345 Compare April 9, 2024 20:30

yui-knk reviewed Apr 13, 2024

View reviewed changes

Comment thread lib/lrama/grammar/rule_builder.rb Outdated

ydah force-pushed the inline-index branch from 4967ded to 41138d9 Compare April 15, 2024 13:49

ydah requested a review from yui-knk April 15, 2024 14:28

ydah force-pushed the inline-index branch from e9d6d43 to f002019 Compare April 18, 2024 14:33

ydah force-pushed the inline-index branch from 82825fb to 6d9b557 Compare May 2, 2024 04:48

ydah added 11 commits May 17, 2024 15:27

Add support for adjusting Index to Inline

71c6f37

Add test code for index adjustment and $n reverse

2435ee6

Fix an order of user_code.references issue

4092011

Support @n style

2b7e0cf

Remove unnecessary codes

d5e722a

Fix a segmentation fault when run calc

0ef85f6

``` ❯ exe/lrama -d sample/calc.y -o calc.c && gcc -Wall calc.c -o calc && ./calc Enter the formula: 1 parse error: syntax error, unexpected NUM [1] 52278 segmentation fault ./calc ```

Remove unused instance variable

604a7e9

Fix an id for inline grammar rules

c87e9f5

Refactor for parameterizing_rule_resolver

39fc2fd

Support inline with parameterizing rule

56b1f45

Add test code for cases with parameterizing rule in rhs for inline

c638e08

ydah force-pushed the inline-index branch from 6d9b557 to c638e08 Compare May 17, 2024 06:30

yui-knk merged commit 48c4434 into ruby:master May 17, 2024

ydah deleted the inline-index branch May 17, 2024 07:42

Navigation Menu

Uh oh!

Add support for adjusting Index to Inline - #394