Use require_relative in the Lrama codebase - #419
Merged
Conversation
If there are many searches in the `$LOAD_PATH` in the user environment, require will perform unnecessary searches that are not needed. In contrast, `require_relative` is efficient because it uses a relative path. Lrama requires Ruby 2.5+, it is possible to use `require_relative`, which was introduced in Ruby 1.9. https://github.com/ruby/lrama/blob/v0.6.9/lrama.gemspec#L14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are many searches in the
$LOAD_PATHin the user environment, require will perform unnecessary searches that are not needed. In contrast,require_relativeis efficient because it uses a relative path.Lrama requires Ruby 2.5+, it is possible to use
require_relative, which was introduced in Ruby 1.9.https://github.com/ruby/lrama/blob/v0.6.9/lrama.gemspec#L14