Skip to content

Organize parser.y - #460

Merged
ydah merged 12 commits into
ruby:masterfrom
ydah:use-new-grammar
Jul 31, 2024
Merged

Organize parser.y#460
ydah merged 12 commits into
ruby:masterfrom
ydah:use-new-grammar

Conversation

@ydah

@ydah ydah commented Jul 20, 2024

Copy link
Copy Markdown
Member
  • Use new racc grammar +, *, ? ?
  • Remove unnecessary line breaks
  • Add midrule_action and empty and empty non-terminal symbols to organize
  • Remove redundant non-terminal symbols.

@ydah
ydah marked this pull request as draft July 20, 2024 17:43
@ydah
ydah force-pushed the use-new-grammar branch from fa5c921 to a59bf02 Compare July 30, 2024 07:27
@ydah
ydah force-pushed the use-new-grammar branch from a59bf02 to 9378b64 Compare July 30, 2024 07:59
@ydah
ydah marked this pull request as ready for review July 30, 2024 08:00
@ydah
ydah requested a review from yui-knk July 30, 2024 12:21
@yui-knk

yui-knk commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator

Seem good! Thank you!

@ydah
ydah merged commit e61bb6f into ruby:master Jul 31, 2024
@ydah
ydah deleted the use-new-grammar branch July 31, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yui-knk yui-knk yui-knk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ydah @yui-knk