Add CI env for C++ and fix errors and warnings when compiling as C++ - #465
Merged
Conversation
This is a follow up of ruby#443
… this behavior is deprecated [-Wdeprecated] ``` clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated] ```
…onst code_location_t' (aka 'const code_location') without a user-provided default constructor
```
..../var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/named_references.cpp:1222:22: error: default initialization of an object of const type 'const code_location_t' (aka 'const code_location') without a user-provided default constructor
static const YYLTYPE yyloc_default
^
= {}
1 error generated.
F/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/typed_midrule_actions.cpp:1222:22: error: default initialization of an object of const type 'const code_location_t' (aka 'const code_location') without a user-provided default constructor
static const YYLTYPE yyloc_default
^
= {}
1 error generated.
```
```
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1437:31: error: expected unqualified-id
yy_repairs *new = (yy_repairs *) YYMALLOC (sizeof (yy_repairs));
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1438:22: error: expected a type
new->id = count;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1439:22: error: expected a type
new->next = 0;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1440:22: error: expected a type
new->stack_length = stack_length;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1441:22: error: expected a type
new->states = (yy_state_t *) YYMALLOC (sizeof (yy_state_t) * (stack_length));
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1442:22: error: expected a type
new->state = new->states + (current->state - current->states);
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1443:30: error: expected a type
YYCOPY (new->states, current->states, current->state - current->states + 1);
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1444:22: error: expected a type
new->repair_length = current->repair_length + 1;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1445:22: error: expected a type
new->prev_repair = current;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1446:22: error: expected a type
new->repair.type = insert;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1447:22: error: expected a type
new->repair.term = (yysymbol_kind_t) yyx;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1450:48: error: expected a type
if (! yy_process_repairs (new, yyx))
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1452:34: error: expected a type
YYFREE (new);
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1457:29: error: expected a type
tail = new;
^
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1473:40: error: expected a type
yy_print_repairs (new);
^
```
``` /var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1196:3: error: expected identifier delete, ^ ```
```
/var/folders/7d/3dfz8sj91zjdmmzwzz1pw84r0000gp/T/error_recovery.cpp:1450:25: error: no matching function for call to 'yy_process_repairs'
if (! yy_process_repairs (reps, yyx))
^~~~~~~~~~~~~~~~~~
```
…ntype' with an rvalue of type 'int'
```
error: cannot initialize return object of type 'enum yytokentype' with an rvalue of type 'int'
return 0;
^
1 error generated.
```
```
Undefined symbols for architecture arm64:
"yylex(YYSTYPE*, code_location*)", referenced from:
yyparse() in named_references-92348a.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FUndefined symbols for architecture arm64:
"yylex(YYSTYPE*, code_location*)", referenced from:
yyparse() in typed_midrule_actions-686229.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
F
```
… this behavior is deprecated ``` clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated] ```
Closed
Collaborator
|
LGTM! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up: #447
fix: #442