Skip to content

Change the -t option, which was reserved, to match bison and behave the same as --debug - #504

Merged
ydah merged 1 commit into
ruby:masterfrom
ydah:t-option
Jan 8, 2025
Merged

Change the -t option, which was reserved, to match bison and behave the same as --debug#504
ydah merged 1 commit into
ruby:masterfrom
ydah:t-option

Conversation

@ydah

@ydah ydah commented Jan 7, 2025

Copy link
Copy Markdown
Member

This PR change the -t option, which was reserved, to match bison, so that it works the same as --debug.

❯ bison -h
Usage: bison [OPTION]... FILE
: (snip)
Tuning the Parser:
  -L, --language=LANGUAGE          specify the output programming language
  -S, --skeleton=FILE              specify the skeleton to use
  -t, --debug                      instrument the parser for tracing
  ^^

… the same as `--debug`

This PR change the `-t` option, which was reserved, to match bison, so that it works the same as `--debug`.

```
❯ bison -h
Usage: bison [OPTION]... FILE
: (snip)
Tuning the Parser:
  -L, --language=LANGUAGE          specify the output programming language
  -S, --skeleton=FILE              specify the skeleton to use
  -t, --debug                      instrument the parser for tracing
  ^^
```
@ydah
ydah merged commit 45720ab into ruby:master Jan 8, 2025
@ydah
ydah deleted the t-option branch January 8, 2025 09:27
yui-knk added a commit to yui-knk/lrama that referenced this pull request Jan 12, 2025
This reverts commit 45720ab, reversing
changes made to b65bc88.
@yui-knk

yui-knk commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator

Note: After this commit is merged into master branch, test-ruby tasks take 60 min to complete (before and after).
This is because -t option is passed to lrama when ripper is build so that a lot of trace information is rendered.
-t option is not needed for ripper build then I stopped passing the option by ruby/ruby@84f0d2d.

@ydah

ydah commented Jan 13, 2025

Copy link
Copy Markdown
Member Author

Thank you so much 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants