Fix ielr tests - #574
Merged
Merged
Conversation
junk0612
force-pushed
the
fix-ielr-tests
branch
5 times, most recently
from
March 1, 2025 15:30
63c7b1f to
dbbc2dc
Compare
yui-knk
reviewed
Mar 2, 2025
| end | ||
|
|
||
| compute_inadequacy_annotations | ||
| # @states.each {|state| state.item_lookahead_set.tap { p _1.transform_keys(&:to_s) }.clear } |
Collaborator
There was a problem hiding this comment.
Is it need to keep this commented out code?
yui-knk
reviewed
Mar 2, 2025
| def compute_transition_bitmaps | ||
| nterm_transitions.map {|goto| | ||
| [goto, Bitmap.from_array(goto.to_state.transitions.map {|transition| transition.next_sym.number })] | ||
| [goto, Bitmap.from_array(goto.to_state.term_transitions.map {|transition| transition.next_sym.number })] |
Collaborator
There was a problem hiding this comment.
[nits] It's better to use shift as block parameter instead of transition.
yui-knk
approved these changes
Mar 2, 2025
Collaborator
Author
|
🙏 thanks for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.