refactor: use macro to remove duplication of workspace inheritable fields getters - #12317
Merged
Conversation
rustbot
added
A-manifest
Member
Author
Not sure why but I had a hard time reproducing it on a Linux machine. @bors try |
Contributor
bors
added a commit
that referenced
this pull request
Jun 28, 2023
refactor: use macro to remove duplication of workspace inheritable fields getters
Contributor
|
💥 Test timed out |
Muscraft
reviewed
Jun 28, 2023
Muscraft
left a comment
Muscraft
left a comment
Member
There was a problem hiding this comment.
Overall this is a good change. One of my biggest regrets with workspace inheritance was not finding a way to reduce the amount of duplicate code. This is an excellent step in that direction!
My only concern would be with the potential drift in the doc comments for the getters as some are handwritten while the rest are generated by the macro. This is a very minor concern that doesn't need to be dealt with in currently, but it is something to note.
weihanglo
force-pushed
the
inheritable-macro
branch
from
June 28, 2023 16:20
324af1d to
e313b61
Compare
Member
Author
|
Thanks for the feedback! It's ready for the next round of review :) |
Muscraft
approved these changes
Jun 29, 2023
Member
|
Not sure why bors didn't work, so I'll approve it again @bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 1, 2023
Update cargo 6 commits in 03bc66b55c290324bd46eb22e369c8fae1908f91..5b377cece0e0dd0af686cf53ce4637d5d85c2a10 2023-06-23 23:27:46 +0000 to 2023-06-30 00:01:00 +0000 - Add READMEs for the credential helpers. (rust-lang/cargo#12322) - Add some more documentation for Source download functions. (rust-lang/cargo#12319) - Don't try to compile cargo-credential-gnome-secret on non-Linux platforms. (rust-lang/cargo#12321) - refactor: use macro to remove duplication of workspace inheritable fields getters (rust-lang/cargo#12317) - doc: should be `.cargo-ok` (rust-lang/cargo#12318) - refactor(registry): extract and rearrange items to their own modules (rust-lang/cargo#12290) r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Use macros to avoid repeating the getter method definitions in workspace inheritable fields.
This also removes some unnecessary clones.
How should we test and review this PR?
I am not sure if it is preferable. Feel free to reject and close.
r? @Muscraft