[macro_metavar_expr_concat] Dogfooding - #128491
Merged
Merged
Conversation
Collaborator
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
O-unix
Noratrieb
reviewed
Aug 1, 2024
| concat_idents!(SYS_, $name), | ||
| $($arg_name),* | ||
| ) as $ret | ||
| syscall(${concat(SYS_, $name)}, $($arg_name),*) as $ret |
Member
There was a problem hiding this comment.
Suggested change
| syscall(${concat(SYS_, $name)}, $($arg_name),*) as $ret | |
| syscall(libc::${concat(SYS_, $name)}, $($arg_name),*) as $ret |
and then delete the comment and import above
Noratrieb
reviewed
Aug 1, 2024
| concat_idents!(SYS_, $name), | ||
| $($arg_name),* | ||
| ) as $ret | ||
| syscall(${concat(SYS_, $name)}, $($arg_name),*) as $ret |
Member
There was a problem hiding this comment.
Suggested change
| syscall(${concat(SYS_, $name)}, $($arg_name),*) as $ret | |
| syscall(libc::${concat(SYS_, $name)}, $($arg_name),*) as $ret |
same here
c410-f3r
force-pushed
the
unlock-rfc-2011
branch
from
August 1, 2024 23:55
1356b76 to
dcbe188
Compare
Contributor
Author
|
Done |
This comment has been minimized.
This comment has been minimized.
c410-f3r
force-pushed
the
unlock-rfc-2011
branch
from
August 2, 2024 00:32
dcbe188 to
b2f7e71
Compare
| concat_idents!(SYS_, $name), | ||
| $($arg_name),* | ||
| ) as $ret | ||
| libc::syscall(libc::${concat(SYS_, $name)}, $($arg_name),*) as $ret |
Member
There was a problem hiding this comment.
Out of curiosity (you do not have to change to this), would this work?
libc::syscall(${concat(libc::SYS_, $name)}, $($arg_name),*) as $ret
workingjubilee
approved these changes
Aug 2, 2024
Comment on lines
-171
to
-173
| // This looks like a hack, but concat_idents only accepts idents | ||
| // (not paths). | ||
| use libc::*; |
Member
There was a problem hiding this comment.
no this absolutely was a brutal hack.
Member
There was a problem hiding this comment.
a beautiful example of why it eas terrible
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
tgross35
added
the
F-macro_metavar_expr_concat
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #124225
Starts inner usage to test the robustness of the implementation.