Skip to content

compiler_fence: fix example - #136079

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:compiler-fence-example
Jan 27, 2025
Merged

compiler_fence: fix example#136079
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:compiler-fence-example

Conversation

@RalfJung

@RalfJung RalfJung commented Jan 26, 2025

Copy link
Copy Markdown
Member

The old example was wrong, an acquire fence is required in the signal handler. To make the point more clear, I changed the "data" variable to use non-atomic accesses.

Fixes #133014

@rustbot

rustbot commented Jan 26, 2025

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 26, 2025
@RalfJung RalfJung mentioned this pull request Jan 26, 2025
Closed
jhpratt
jhpratt reviewed Jan 26, 2025
View reviewed changes
Comment thread library/core/src/sync/atomic.rs Outdated
Comment thread library/core/src/sync/atomic.rs Outdated
Comment thread library/core/src/sync/atomic.rs
@RalfJung
RalfJung force-pushed the compiler-fence-example branch from 58afc6b to 9c972c0 Compare January 27, 2025 00:34
@jhpratt

jhpratt commented Jan 27, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 9c972c0 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
@fmease fmease mentioned this pull request Jan 27, 2025
Merged
@bors
bors merged commit bd2f6d7 into rust-lang:master Jan 27, 2025
@rustbot rustbot added this to the 1.86.0 milestone Jan 27, 2025
@RalfJung
RalfJung deleted the compiler-fence-example branch January 27, 2025 16:13
@fmease

fmease commented Feb 2, 2025

Copy link
Copy Markdown
Member

@bors r- ('fixing' desync)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhpratt jhpratt jhpratt left review comments

Assignees

@jhpratt jhpratt

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

compiler_fence example is misleading

5 participants

@RalfJung @rustbot @jhpratt @bors @fmease