fully deprecate the legacy integral modules - #146882

cyrgani · 2025-09-22T11:58:40Z

This PR implements the last step of #68490: marking the std::u8 etc. modules and the constants in std::f32 and std::f64 (but not the undeprecated consts submodule) as fully deprecated.

Revival of #107587 (cc @tgross35).

Closes: #68490

r? libs-api

BurntSushi · 2025-09-22T12:45:34Z

I'm still kind of meh on these deprecations personally, but we should probably finish what was started.

With that said, I'm strongly opposed to applying #[doc(hidden)] to deprecated items. I'm not sure why you're doing that here. It seems like an obviously bad user experience that only serves to gaslight users. Imagine reading old code, wondering what a function does and then going to look it up in the docs only to find that... it isn't there?

Once the #[doc(hidden)] attributes are removed, I'd be happy to kick off an FCP.

cyrgani · 2025-09-22T13:23:56Z

I've removed the #[doc(hidden] attributes.
Regarding why I added them, it is mostly the feeling that having twelve deprecated modules right on the front page of the std documentation is not a good user experience either.
Also, people who would search the docs for core::u8::MAX would still get u8::MAX as their first search result to find out what the constant means.

BurntSushi · 2025-09-22T13:26:53Z

Regarding why I added them, it is mostly the feeling that having twelve deprecated modules right on the front page of the std documentation is not a good user experience either.

Perhaps! But the solution is definitely not to completely hide them.

Also, people who would search the docs for core::u8::MAX would still get u8::MAX as their first search result to find out what the constant means.

Sure, same thing applies here. I don't know anything about how rustdoc's search result ranking works, but it seems reasonable that it could take deprecation status into account.

BurntSushi · 2025-09-22T13:27:51Z

@rfcbot merge

rust-rfcbot · 2025-09-22T13:27:53Z

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Needed for rust-lang/rust#146882.

…mdev give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to rust-lang#146882.

Rollup merge of #147373 - cyrgani:cyrgani-patch-1, r=ibraheemdev give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to #146882.

…mdev give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to rust-lang#146882.

give a better example why `std` modules named like primitives are needed A small update to the `std` `lib.rs` introduction to replace mentions of `std::i32` (never needed) with `std::char` (sometimes needed). Related to rust-lang/rust#146882.

rust-rfcbot · 2025-10-15T15:28:40Z

🔔 This is now entering its final comment period, as per the review above. 🔔

RalfJung · 2025-10-23T08:08:27Z

marking the std::u8 etc. modules as fully deprecated and as #[doc(hidden)].

It seems the doc(hidden) part got removed; please also update the PR description since it will permanently become part pf the git history.

clarfonthey · 2026-07-30T13:36:05Z

Did an additional pass of review, and it looks like none of the outstanding issues still are present after rebase. This does only exactly what it mentions, which is deprecate:

std::{uN, iN}::{self, MIN, MAX}
std::fN::{RADIX, MANTISSA_DIGITS, DIGITS, etc} (but not std::fN or std::fN::consts)

Gonna nominate for next week's meeting even though this passed FCP just to verify we're cool making this happen next release, since it's been a while and people might have forgotten about it.

Once we verify that, r=clarfonthey,BurntSushi on this one.

joshtriplett · 2026-08-04T15:44:38Z

@bors r+

clarfonthey · 2026-08-04T15:48:51Z

@bors r=clarfonthey,BurntSushi,joshtriplett

rust-bors · 2026-08-04T15:48:54Z

📌 Commit 0115f0e has been approved by clarfonthey,BurntSushi,joshtriplett

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: manually handling queue due to backlog

…uwer Rollup of 22 pull requests Successful merges: - #160426 (`rust-analyzer` subtree update) - #160372 (Derive the allocator used by tools from rustc's allocator) - #146882 (fully deprecate the legacy integral modules) - #158727 (std: use `readdir` on nearly all UNIX platforms) - #159727 (Various steps in moving away from the big reflection enum to reflection functions) - #160443 (normalize in relations, not generalize, when relating infer with alias) - #160457 (implement -Zllvm-target-feature) - #160480 (Single-pass ASCII lower/upper case conversion) - #160502 (Reduce number of miri tests executed on PR CI) - #157430 (std::random: use little-endian for reproducibility) - #158110 (fix macro attribute feature-gate span) - #159975 (Use real ThinVec in StmtDebugInfos) - #160001 (Suggest mutable method when iterating over binding) - #160024 (Fix mono reachability with no-op landing pads) - #160154 (Add regression test for HRTB associated type projection closure) - #160176 (No more `tests/ui/issues`!) - #160326 (Remove hidden_glob_reexports) - #160407 (Add regression tests for a number of ICEs and diagnostics issues labelled `E-needs-test`) - #160430 (bootstrap: Don't produce mutated/filtered PathSets during command-line matching) - #160472 (Minor fixes to `core::io` & `alloc::io` Documentation) - #160486 (Remove unused `FreeRegionsVisitor`) - #160496 (clarify non-determinism docs for algebraic operations) Failed merges: - #160501 (Add bootstrap CLI snapshot test for testing miri)

@tgross35

Rollup merge of #146882 - cyrgani:deprecate-legacy-int-mods, r=clarfonthey,BurntSushi,joshtriplett fully deprecate the legacy integral modules This PR implements the last step of #68490: marking the `std::u8` etc. modules and the constants in `std::f32` and `std::f64` (but not the undeprecated `consts` submodule) as fully deprecated. Revival of #107587 (cc @tgross35). Closes: #68490 r? libs-api

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#160426 (`rust-analyzer` subtree update) - rust-lang/rust#160372 (Derive the allocator used by tools from rustc's allocator) - rust-lang/rust#146882 (fully deprecate the legacy integral modules) - rust-lang/rust#158727 (std: use `readdir` on nearly all UNIX platforms) - rust-lang/rust#159727 (Various steps in moving away from the big reflection enum to reflection functions) - rust-lang/rust#160443 (normalize in relations, not generalize, when relating infer with alias) - rust-lang/rust#160457 (implement -Zllvm-target-feature) - rust-lang/rust#160480 (Single-pass ASCII lower/upper case conversion) - rust-lang/rust#160502 (Reduce number of miri tests executed on PR CI) - rust-lang/rust#157430 (std::random: use little-endian for reproducibility) - rust-lang/rust#158110 (fix macro attribute feature-gate span) - rust-lang/rust#159975 (Use real ThinVec in StmtDebugInfos) - rust-lang/rust#160001 (Suggest mutable method when iterating over binding) - rust-lang/rust#160024 (Fix mono reachability with no-op landing pads) - rust-lang/rust#160154 (Add regression test for HRTB associated type projection closure) - rust-lang/rust#160176 (No more `tests/ui/issues`!) - rust-lang/rust#160326 (Remove hidden_glob_reexports) - rust-lang/rust#160407 (Add regression tests for a number of ICEs and diagnostics issues labelled `E-needs-test`) - rust-lang/rust#160430 (bootstrap: Don't produce mutated/filtered PathSets during command-line matching) - rust-lang/rust#160472 (Minor fixes to `core::io` & `alloc::io` Documentation) - rust-lang/rust#160486 (Remove unused `FreeRegionsVisitor`) - rust-lang/rust#160496 (clarify non-determinism docs for algebraic operations) Failed merges: - rust-lang/rust#160501 (Add bootstrap CLI snapshot test for testing miri)

@tgross35

…nthey,BurntSushi,joshtriplett fully deprecate the legacy integral modules This PR implements the last step of #68490: marking the `std::u8` etc. modules and the constants in `std::f32` and `std::f64` (but not the undeprecated `consts` submodule) as fully deprecated. Revival of #107587 (cc @tgross35). Closes: #68490 r? libs-api

`u32::max_value()` et al got deprecated last week as part of rust-lang/rust#160517 in rust-lang/rust#146882

* use u64 internally to track file offsets This replaces usize in a lot of places. Besides being a technically breaking change, this should not impact functionality. Solves a TODO left long ago in the entry code of parse. * inline LogicalOffset as per review comment * self-review to simplify logic slightly * convert wasmprinter and wasm-encoder * convert wasm-metadata, wasm-mutate, wast (tests) * fix msrv issue * convert wasm-tools bins and fuzz * fix some lints and self-review * fix clippy lints and adjust test on error message * remove and inline MemOffset structure by review * remove InMemData from two uses * move range conversion into an OffsetCoverter struct this is now part of the return from the parse functions, so it's impossible to miss if you need access to it * remove OffsetConverter from parse_all Almost all of the time, parse_all is called at offset 0. In these cases, the conversion is simplified and not needed. * remove references to OffsetConverter::from_start(0) Use 'simply' as-casts instead. In these cases, we simply assert that our casting logic is sound and trust in the parser to not emit offsets that silently truncate * oops missed one due to not building wit-dylib locally * convert wasm-tools to as-casts * remove ConvertOffset what's a few as casts among friends. certainly too simple of an API to leave in, right? * minify the diff by reverting some unrelated changes * two more stylistic changes for diff optimization * fix clippy warnings `u32::max_value()` et al got deprecated last week as part of rust-lang/rust#160517 in rust-lang/rust#146882 * do not silently truncate data input the parser will return an Error, the binary reader will panic

rustbot assigned BurntSushi Sep 22, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 22, 2025

cyrgani added T-libs-api [DEPRECATED; DO NOT USE] and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 22, 2025

This comment has been minimized.

Sign in to view

cyrgani force-pushed the deprecate-legacy-int-mods branch from 438bfa3 to 7fa9c6a Compare September 22, 2025 13:11

This comment has been minimized.

Sign in to view

cyrgani changed the title ~~fully deprecate and hide the legacy integral modules~~ fully deprecate the legacy integral modules Sep 22, 2025

rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 22, 2025

cyrgani mentioned this pull request Sep 22, 2025

Remove usage of the to-be-deprecated core::f32, core::f64 items rust-lang/compiler-builtins#1022

Merged

tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request Sep 22, 2025

Remove usage of the to-be-deprecated core::f32, core::f64 items

829c4f8

Needed for rust-lang/rust#146882.

cyrgani mentioned this pull request Oct 5, 2025

give a better example why std modules named like primitives are needed #147373

Merged

rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 15, 2025

rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 25, 2025

rust-cloud-vms Bot force-pushed the deprecate-legacy-int-mods branch from dd7b1c2 to 0115f0e Compare July 30, 2026 11:33

clarfonthey added S-waiting-on-t-libs-api [DEPRECATED; DO NOT USE] I-libs-api-nominated [DEPRECATED; DO NOT USE] and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2026

clarfonthey changed the title ~~fully deprecate the legacy integral modules~~ fully deprecate the legacy primitive modules Jul 30, 2026

clarfonthey changed the title ~~fully deprecate the legacy primitive modules~~ fully deprecate the legacy integral modules Jul 30, 2026

This comment was marked as outdated.

Sign in to view

joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 4, 2026

This comment was marked as outdated.

Sign in to view

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2026

This comment was marked as outdated.

Sign in to view

clarfonthey removed the S-waiting-on-t-libs-api [DEPRECATED; DO NOT USE] label Aug 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2026

Mark-Simulacrum removed the I-libs-api-nominated [DEPRECATED; DO NOT USE] label Aug 4, 2026

JonathanBrouwer mentioned this pull request Aug 4, 2026

Rollup of 22 pull requests #160517

Merged

rust-bors Bot merged commit e1d8b7c into rust-lang:main Aug 5, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Aug 5, 2026

cyrgani deleted the deprecate-legacy-int-mods branch August 5, 2026 07:45

RalfJung mentioned this pull request Aug 6, 2026

portable-simd is entirely untested in rust-lang/rust #160607

Closed

WorldSEnder added a commit to WorldSEnder/wasm-tools that referenced this pull request Aug 12, 2026

fix clippy warnings

d8ce95c

`u32::max_value()` et al got deprecated last week as part of rust-lang/rust#160517 in rust-lang/rust#146882

Uh oh!

Uh oh!

Conversation

cyrgani commented Sep 22, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

BurntSushi commented Sep 22, 2025

Uh oh!

This comment has been minimized.

cyrgani commented Sep 22, 2025

Uh oh!

BurntSushi commented Sep 22, 2025

Uh oh!

BurntSushi commented Sep 22, 2025

Uh oh!

rust-rfcbot commented Sep 22, 2025 • edited by Amanieu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-rfcbot commented Oct 15, 2025

Uh oh!

RalfJung commented Oct 23, 2025

Uh oh!

clarfonthey commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshtriplett commented Aug 4, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

clarfonthey commented Aug 4, 2026

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

cyrgani commented Sep 22, 2025 •

edited by rustbot

Loading

rust-rfcbot commented Sep 22, 2025 •

edited by Amanieu

Loading

clarfonthey commented Jul 30, 2026 •

edited

Loading