Align internal build OIDC identity - #1568
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the internal-only OIDC guard to the exact name-only subject observed in run 31530143690. Production behavior is unchanged.
Note
Medium Risk
Touches OIDC identity verification used before assuming AWS ECR roles, but only for the internal environment and only to match the observed subject.
Overview
Updates the internal-only OIDC subject check in
_build-cloud.ymlto the name-only formrepo:sourcebot-dev/sourcebot:environment:internal, matching the subject GitHub actually issues.Production/staging behavior is unchanged; this only affects the guard that runs when
environment == 'internal'.Reviewed by Cursor Bugbot for commit f369ab1. Bugbot is set up for automated code reviews on this repo. Configure here.