[6.x] Add min and max validation rules when configured as zero - #15175
Merged
Conversation
`Integer::rules()` and `Floatval::rules()` used truthy checks, so a `min` or `max` of `0` was treated as unset and silently dropped from validation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a
minormaxof0on the Integer and Float fieldtypes was silently ignored, so the value never got validated.This was happening because
Integer::rules()andFloatval::rules()used truthy checks (if ($min = $this->config('min'))), which treat a configured0as unset. Since #12395 made Min, Max and Step user-facing config fields on both fieldtypes, it became easy to hit — setting Min to0to prevent negative numbers did nothing at all.This PR fixes it by checking for
nullinstead of truthiness.Related: #8932
Caused by #12395