Skip to content

Add more tests for duplicated named capture groups. - #3709

Merged
ptomato merged 3 commits into
mainfrom
named-groups
Nov 4, 2022
Merged

Add more tests for duplicated named capture groups.#3709
ptomato merged 3 commits into
mainfrom
named-groups

Conversation

@Ms2ger

@Ms2ger Ms2ger commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@Ms2ger
Ms2ger requested a review from ptomato November 3, 2022 14:46
@Ms2ger
Ms2ger requested a review from a team as a code owner November 3, 2022 14:46
@Ms2ger
Ms2ger force-pushed the named-groups branch 2 times, most recently from 47655aa to 95eaa8b Compare November 3, 2022 14:52
ptomato
ptomato previously approved these changes Nov 3, 2022

@ptomato ptomato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cc @bakkot

Comment thread test/built-ins/RegExp/named-groups/duplicate-names-matchall.js
Comment thread test/built-ins/RegExp/named-groups/duplicate-names-split.js

@ptomato ptomato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ptomato
ptomato merged commit 5d8ebdf into main Nov 4, 2022
@ptomato
ptomato deleted the named-groups branch November 4, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants