fix: fix terminal webgl context memory leak #279579
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a WebGL context memory leak in the terminal by ensuring the WebGL renderer is properly disposed when a terminal is closed. The issue was that GPU memory was not being released even after terminal canvases were destroyed, causing memory to accumulate (167MB for 10 idle terminals).
Key Changes:
- Added explicit WebGL renderer disposal in the
XtermTerminal.dispose()method
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Contributor
Author
lszomoru
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My testing found that on my Mac, when 10 terminals were opened and left idle for a period of time, the GPU process memory increased by 167MB (319MB ->486MB). After deleting all terminals, the memory of GPU processes will not significantly decrease.
By taking a snapshot of JavaScript, it has been confirmed that the corresponding canvas has been destroyed, but the
WebGL2RenderingContexthas not been destroyed, resulting in the inability to release rendering memory.