Fix: Replace terminal view lifecycle hack with Event.once #285661
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces a manual event listener pattern with the more robust Event.once pattern in terminalView.ts. The change ensures proper lifecycle management by automatically disposing the event listener after its first invocation, preventing potential memory leaks when handling terminal connection state changes.
Key Changes:
- Replaced
this._register(this._terminalService.onDidChangeConnectionState(() => {withthis._register(Event.once(this._terminalService.onDidChangeConnectionState)(() => { - Removed TODO comments about improving lifecycle management
Tyriar
requested changes
Jan 2, 2026
Tyriar
approved these changes
Jan 2, 2026
lszomoru
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to the fix in terminalTabbedView.ts: replaces a manual 'TODO' event listener in terminalView.ts with a robust Event.once pattern. Ensures proper disposal and prevents memory leaks during terminal connection state changes.