stream: make checking pendingcb on WritableStream backward compatible #54142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54142 +/- ##
==========================================
+ Coverage 87.06% 87.07% +0.01%
==========================================
Files 643 643
Lines 181576 181576
Branches 34894 34895 +1
==========================================
+ Hits 158088 158111 +23
+ Misses 16759 16749 -10
+ Partials 6729 6716 -13
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ronag
approved these changes
Aug 1, 2024
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
jakecastelli
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in fafc845 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #53438 we tried to fix
stream.finishedto wait calling its callback until all the pending callback has been called. However the patch breaks the users who use a very old version of the stream which does not havependingcbstate on theWritableStream.I am not sure if we should patch this or we should encourage the user to use a more up to date version.
Fixes: #54131
Refs: #54131 (comment)