-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
sqlite,test,doc: accept Buffer and URL as paths #56991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite,test,doc: accept Buffer and URL as paths #56991
Conversation
446d48b to
18fe76b
Compare
2a608e1 to
5b5a8cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56991 +/- ##
==========================================
- Coverage 90.33% 90.25% -0.08%
==========================================
Files 630 630
Lines 184537 184681 +144
Branches 36077 36138 +61
==========================================
- Hits 166693 166686 -7
- Misses 10950 11021 +71
- Partials 6894 6974 +80
|
06d30bf to
4561203
Compare
303de33 to
7019435
Compare
07a5b31 to
114df4d
Compare
|
I think this needs a rebase to fix the CI issue. cc: @nodejs/sqlite since this PR was opened before the team existed. |
| }); | ||
| }); | ||
|
|
||
| test('throws if the URL does not have the file: scheme', (t) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also check the happy path.
Can you try URL("file://path/to/db.db?mode=ro") and verify that writes error out?
Passing a file:// or file: as URL as a string or Buffer should also be supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
e145acb to
7d1111f
Compare
|
Landed in c7cf677 |
Closes #56940
This PR adds the capability to the sqlite module to accept Buffer and URL as the database location.