Repository navigation
Fix a bug in universal attack. - #154
Merged
Merged
Conversation
YaxinLi0-0
approved these changes
Apr 4, 2024
YaxinLi0-0
reviewed
Apr 4, 2024
YaxinLi0-0
left a comment
YaxinLi0-0
left a comment
Collaborator
There was a problem hiding this comment.
Here it is num_images = len(dataloader), where dataloader is a list of images and corresponding labels.
YaxinLi0-0
approved these changes
Apr 4, 2024
Contributor
Author
|
I see, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug in the original implementation of universal attack, that is, a undefined variable was referred before.
Moreover, I also found that torch.autograd dropped the function of zero_gradients, so I also replace it with a new function.
Could you please review it and give some feedback? Thanks.