Repository navigation
Conversation
|
@michaelsilva is attempting to deploy a commit to the Lucasbonomi Team on Vercel. A member of the Team first needs to authorize it. |
michaelsilva
force-pushed
the
feat/shape-rendering-geometric-precision
branch
4 times, most recently
from
October 6, 2026 17:00
75c51f0 to
66e52fb
Compare
Promote a subpixel silhouette only after the existing primary ray passes its local distance minimum without hitting it, so exact-hit pixels shade once. Preserve the auto shader, foreground-over-background coverage, the scene-bound fast path, GLSL/WGSL parity, and repo-native tests/docs. Decision number is intentionally deferred behind PR #6. Refs LukyVj#2
michaelsilva
force-pushed
the
feat/shape-rendering-geometric-precision
branch
from
October 6, 2026 17:02
3c04386 to
3931586
Compare
LukyVj
added a commit
that referenced
this pull request
Oct 8, 2026
…c-precision feat: add geometricPrecision edge coverage Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the antialiasing direction agreed in #2 without supersampling, extra camera rays, an extra pass, or a larger backing store.
What changes
scene { shape-rendering: geometricPrecision; };autoremains the default and emits the previous shader unchangedt * pixelSizebecomes silhouette coverage; a ray still converging on an exact hit never becomes an edge candidate0is never promoted as a shape silhouetteDecision sequencing
PR #6 is the older contribution and owns decision 139. This draft therefore intentionally does not add a decision entry yet rather than introducing an out-of-order
140on a branch where 139 is absent.After #6 lands, this PR should take decision 140, update its roadmap reference, and advance the repository's next-decision pointer in the same change.
Tests in the PR
autoshader identity, syntax validation,@media, passed-near-miss codegen and WGSL loweringThe precision helper also passes standalone TypeScript syntax checking. An analytic 96x72 sphere trace of the same camera geometry produces silhouette candidates on missed grazing rays and zero candidates on exact-hit rays.
Performance proof before review
Keeping this PR in draft until the requested real-GPU comparison is recorded. The repository benchmark requires visible Chromium on a real GPU.
To isolate the feature cost, compare the committed branch (
auto) with the same branch plus a temporary working-tree opt-in on the heavyorreryscene:node -e 'const fs=require("fs"),p="src/scenes/orrery.gss";let s=fs.readFileSync(p,"utf8");s=s.replace("\nscene {","\nscene {\n shape-rendering: geometricPrecision;");fs.writeFileSync(p,s)' npm run bench:compare -- HEAD --scenes orrery --dpr 2 git restore src/scenes/orrery.gssThis measures
autoversusgeometricPrecisionon otherwise identical source. The visual diff is expected; the requested evidence is the before/after frame/GPU timing inbench-results/compare.md.Vercel currently reports the external-fork authorization gate, not a build result.
Fixes #2