Repository navigation
[server] Fix remote log start offset of RemoteLogManifest may expose an expired physical prefix - #3956
Merged
wuchong merged 4 commits intoAug 12, 2026
Conversation
Report the manifest-visible logical range through the existing remote log offset accessors without renaming the API or RPC fields. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 8/8 AI-Contributed/UT: 11/11
gyang94
marked this pull request as ready for review
August 12, 2026 06:56
Clarify that the existing remote log offset accessors expose the manifest logical range, which may differ from physical segment boundaries. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 18/18 AI-Contributed/UT: 0/0
Put the manifest-visible logical range semantics first and remove the unnecessary comparison with the last segment physical end offset. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 20/20 AI-Contributed/UT: 0/0
Keep the documentation focused on the manifest-visible logical range. Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5 AI-Contributed/Feature: 6/6 AI-Contributed/UT: 0/0
1 task done
2 tasks done
wuchong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remote log manifests can expose a logical range narrower than the physical ranges of their persisted segments. The aggregate manifest offsets are propagated as the remotely readable range, so they must be derived from logical boundaries.
Brief change log
RemoteLogManifest#getRemoteLogStartOffsetreturn the minimum logical start offset.RemoteLogManifest#getRemoteLogEndOffsetreturn the maximum logical end offset.Tests
mvn -o -pl fluss-common -Dtest=RemoteLogManifestOverlapTest testAPI and Format
No API, RPC field, or storage-format changes.
Documentation
No documentation changes.
Generative AI disclosure