Repository navigation
[GraphQL] Better detection of collection types - #3327
Merged
alanpoulain merged 1 commit intoDec 23, 2019
Merged
Conversation
This was referenced Dec 24, 2019
Closed
dunglas
added a commit
that referenced
this pull request
Jan 13, 2020
* 2.5: Update CHANGELOG.md [GraphQL] Better detection of collection types (#3327) Add tests for building JSON Schema of non-resource class Fix JSON Schema generation for non-resource class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems some people were having issues when not using Doctrine and when a resource had a collection property.
In this case, the
DoctrineExtractor(https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php) is not used and thePhpDocExtractor(https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php) is used instead.The best way to detect if a type is a collection is to see if the value type has a classname.
It's a long way from #1746 😅