[norkunas]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	yes
Tickets	-
License	MIT
Doc PR	api-platform/docs#1023

When having many validation groups generators for resources, you need to make every generator as a public service, and this doesn't work with _instanceof configuration where you could add a custom marker and make those services public, because symfony doesn't detect that those services are used and removes from container.

This adds ApiPlatform\Core\Validator\ValidationGroupsGeneratorInterface so apps can leverage the autoconfiguration + autowiring of those generators. Generators are collected and registered in a custom service locator, but consumers won't need anymore any configuration for them if will implement the interface. For not breaking backwards compatibility left the full service container as a fallback.

TODO:

• Add more tests if needed?
• Make docs PR

[soyuka]

nice job, we should add a unit test implementing a validationgroupsgenerator

[norkunas]

Also updated return typehint from generator interface not to be strict and allow return GroupSequence for consistency.

[norkunas]

ping :)

[norkunas]

Updated, but I don't understand what's wrong with the tests. How a single definition can affect another definitions 🤔

[teohhanhui]

Error: Call to a member function setPublic() on null

Looks like there's a missing mock?

[norkunas]

Error: Call to a member function setPublic() on null

Looks like there's a missing mock?

Which mock?

[teohhanhui]

Which mock?

The ChildDefinition prophecy must return the same instance on addTag(...), e.g. phpspec/prophecy#190 (comment)

My suggestion is to add:

$this->childDefinitionProphecy->addTag(Argument::type('string'))->willReturn($this->childDefinitionProphecy);

in getBaseContainerBuilderProphecy method.

[norkunas]

Which mock?

The ChildDefinition prophecy must return the same instance on addTag(...), e.g. phpspec/prophecy#190 (comment)

My suggestion is to add:

$this->childDefinitionProphecy->addTag(Argument::type('string'))->willReturn($this->childDefinitionProphecy);

in getBaseContainerBuilderProphecy method.

Didn't help 🤦‍♂️ 😁

[teohhanhui]

Let me fix this...

[teohhanhui]

Thanks @norkunas! 🎉 🚀