Repository navigation
Browser: Fix delayed Agents window pane resizing - #345336
Merged
Merged
Conversation
Restore minimized editor panes from focused main-group activation, including native Browser and Canvas WebContentsViews. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Base:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The focus guard still accepts modal groups and stale document focus, allowing unintended resizing of the main Editor/Chat split.
2 open issues
What changed in this PR
Addresses delayed pane resizing in the Agents window by restoring a minimized Editor pane on focused editor-group activation, including native Integrated Browser and Canvas focus.
Changes:
- Adds an activation listener with window and focus guards.
- Adds regression coverage for DOM focus, native focus, other-window activation, and listener disposal.
| File | Description |
|---|---|
src/vs/sessions/test/browser/workbench.test.ts |
Tests focus guards and activation-listener disposal. |
src/vs/sessions/browser/workbench.ts |
Registers focused editor-group activation to restore the minimized Editor pane. |
Review effort: Balanced
Track focus on every main editor pane so modal, auxiliary, and programmatic group activations cannot resize the Sessions split. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Joaquín Ruales (jruales)
changed the title
Expose the existing editor part focus event and let Sessions consume the platform-owned aggregation instead of mirroring group and pane lifecycle. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Joaquín Ruales (jruales)
marked this pull request as ready for review
October 31, 2026 06:16
Joaquín Ruales (jruales)
enabled auto-merge (squash)
October 31, 2026 06:44
Vijay Upadya (vijayupadya)
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344364
Exposes the editor part's existing aggregated focus event through
IEditorPartand uses it to restore a minimized Editor pane as soon as the main editor part receives focus, including nativeWebContentsViewfocus from Integrated Browser and Canvas. The editor subsystem continues to own group and pane lifecycle, while Sessions retains the minimized-pane layout policy and its DOM focus/mousedown fallbacks.CC: Kyle Cutler (@kycutler)
Validation
npm run build-fast -- --client-only— passednpm run typecheck-client— passednpm run eslint -- src/vs/workbench/services/editor/common/editorGroupsService.ts src/vs/workbench/test/browser/workbenchTestServices.ts src/vs/sessions/browser/workbench.ts src/vs/sessions/test/browser/workbench.test.ts— passednpm run test-browser-no-install -- --run src/vs/sessions/test/browser/workbench.test.ts --browser chromium— passed, 141 tests./scripts/test.sh --run src/vs/sessions/test/browser/workbench.test.ts --grep "restores a minimized Editor"— passedcopilot-chat-progresscanvas — from Chat focus and a 300 px Canvas pane, a native click in the canvas expanded it to 958 px; a real Chat click returned it to 300 px and it stayed stable beyond two seconds🤖 Written by GitHub Copilot on behalf of Joaquín Ruales (@jruales).