Repository navigation
fix build on OpenBSD by defining Self() - #37301
Merged
Merged
Conversation
GordonTheTurtle
added
dco/no
Member
|
Thanks for contributing! Can you sign off your commit (you can use the instructions that @GordonTheTurtle provided above) otherwise CI won't pass 😅 |
Signed-off-by: Fabian Raetz <fabian.raetz@gmail.com>
GordonTheTurtle
removed
the
dco/no
Codecov Report
@@ Coverage Diff @@
## master #37301 +/- ##
==========================================
+ Coverage 34.84% 35.05% +0.21%
==========================================
Files 610 609 -1
Lines 45006 45000 -6
==========================================
+ Hits 15681 15774 +93
+ Misses 27210 27112 -98
+ Partials 2115 2114 -1 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
While building all tools from https://github.com/ethereum/go-ethereum on OpenBSD, I got an error because Self was not defined in
reexec/command_unsupported.go.- How I did it
This PR defines the method.
- How to verify it
It builds now under OpenBSD. I did not do any runtime testing though.
- Description for the changelog
fix the build on OpenBSD.