Skip to content

Update overflow-checks option #3624

Closed as not planned
Closed as not planned

Description

@zhassan-aws

This is a follow up from the discussion in #3620.

Requested feature: Kani's options to enable/disable overflow:

$ kani --help | grep overflow
      --overflow-checks
          Turn on default overflow checks
      --no-overflow-checks
          Turn off default overflow checks

give the impression that they're relevant to all types even though they only control overflow for floating-point types:

if self.args.checks.overflow_on() {

We need to either change the option name to float-overflow-checks or just float-checks (since it also controls CBMC's --nan-check) or at least update the help to clarify that the option only applies to floating-point checks.

Activity

  1. celinval commented on Oct 21, 2024

    @celinval
    Contributor

    Why not remove float overflow checks in the first place? They are well-defined operations in Rust and they can be programmatically checked.

  2. zhassan-aws commented on Oct 21, 2024

    @zhassan-aws
    ContributorAuthor

    Agreed. I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [C] Feature / EnhancementA new feature request or enhancement to an existing feature.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions