Repository navigation
Settign LANG=C modifies the --version behavior #78005
Description
| BPO | 33824 |
|---|---|
| Nosy | @vstinner, @jwilk, @ned-deily, @hroncok, @miss-islington |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2018-06-15.22:37:51.828>
created_at = <Date 2018-06-10.19:35:37.667>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
title = 'Settign LANG=C modifies the --version behavior'
updated_at = <Date 2018-06-15.22:37:51.825>
user = 'https://github.com/hroncok'bugs.python.org fields:
activity = <Date 2018-06-15.22:37:51.825>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-06-15.22:37:51.828>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2018-06-10.19:35:37.667>
creator = 'hroncok'
dependencies = []
files = []
hgrepos = []
issue_num = 33824
keywords = ['patch']
message_count = 7.0
messages = ['319238', '319239', '319627', '319629', '319681', '319684', '319686']
nosy_count = 5.0
nosy_names = ['vstinner', 'jwilk', 'ned.deily', 'hroncok', 'miss-islington']
pr_nums = ['7712', '7730']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33824'
versions = ['Python 3.7', 'Python 3.8']
Activity
hroncok commentedon Jun 10, 2018
On 3.6, setting LANG to C did not affect the --version behavior:
On 3.7.0b5 it does.
My locale:
BTW I'm running Fedora builds of Python, where we have PEP-538 on 3.6 as well https://fedoraproject.org/wiki/Changes/python3_c.utf-8_locale
ned-deily commentedon Jun 10, 2018
Odd. I see the same behavior with the python.org macOS builds so it's not just Fedora.
jwilk commentedon Jun 15, 2018
First bad commit is:
9454060
(bpo-29240, bpo-32030: Py_Main() re-reads config if encoding changes)
vstinner commentedon Jun 15, 2018
The bug is a regression caused by the PEP-540 (UTF-8 Mode) and my work to rewrite Py_Main(). My PR 7712 fixes the bug.
vstinner commentedon Jun 15, 2018
New changeset 6c5a4b3 by Victor Stinner in branch 'master':
bpo-33824, bpo-32030: Fix pymain_read_conf() (GH-7712)
6c5a4b3
miss-islington commentedon Jun 15, 2018
New changeset 046da16 by Miss Islington (bot) in branch '3.7':
bpo-33824, bpo-32030: Fix pymain_read_conf() (GH-7712)
046da16
vstinner commentedon Jun 15, 2018
Ned: I let you decide if this bug should be backported to 3.7.0 final or not.
I would prefer to see this fix in 3.7.0, since Py_Main() refactoring was complex and maybe this bug hides another bug. The memset() is safe and make the code more reliable.