Repository navigation
gh-94309: Deprecate typing.Hashable/Sized - #94626
Conversation
To be consistent with PEP 585, deprecated aliases should not raise any DeprecationWarning.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
MonadChains
changed the title
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Deprecating in 3.12 is correct. I think this is almost ready to merge. Good work!
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Could you add a row to this table at the bottom of the page, as well? https://docs.python.org/3.12/library/typing.html#deprecation-timeline-of-major-features
|
@MonadChains congrats on your first contribution to CPython 🎉 . I look forward to more of your contributions in the future. |
|
Shall we also add this to "What’s New In Python 3.12" in the docs? Because we don't have a set version for removal, it can go in the "Pending Removal in Future Versions" section: https://docs.python.org/3.12/whatsnew/3.12.html#pending-removal-in-future-versions (Sorry for the late suggestion!) |
Yes we should. |
#94309
To be consistent with PEP 585, deprecated aliases should not raise any DeprecationWarning.
I put as first version of deprecation the upcoming Python 3.12 (I am not fully sure about this though).