Edition key should be per-target, not per-package #5661

Activity

1. nrc

   added

   P-highPriority: HighPriority: High

   Rust-2018

   on Jun 27, 2018
2. alexcrichton commented on Jun 28, 2018

   

   alexcrichton

   on Jun 28, 2018

   Member

   More actions

   Seems plausible to me! That way existing crates could migrate one Target at a time instead of all at once
3. dtolnay commented on Jul 29, 2018

   

   dtolnay

   on Jul 29, 2018

   Member

   More actions

   @dwijnand or @nrc, could you clarify for someone who is not familiar with Cargo what counts as a "target"? Would this allow selecting an edition at the granularity of individual top-level test files, or would that be a different feature request?

   [[test]]
   name = "rust2018"
   edition = "2018"

   I am interested in being able to test bitflags's support for being used in 2018-style macro imports, while keeping our existing 2015-style tests. See bitflags/bitflags#167.
4. Mark-Simulacrum

   added

   rust-2018-preview

   on Jul 29, 2018
5. alexcrichton commented on Jul 29, 2018

   

   alexcrichton

   on Jul 29, 2018

   Member

   More actions

   @dtolnay your exact PR to bitflags is actually what @dwijnand's PR is enabling.

   "Targets" in Cargo are basically the same thing as "rustc invocations" or crates, so things like unit tests, libraries, binaries, examples, unit tests for librararies, etc, are all different targets.

   👍React with 👍1Reacted by David Tolnay
6. bors

   added a commit that references this issue on Jul 31, 2018

   Auto merge of #5816 - dwijnand:edtion-per-target, r=alexcrichton

   ...

   This issue will close once commit 4b95e8c is merged into the 'master' branch.

   4b95e8c
7. bors

   closed this as completedin #5816on Jul 31, 2018