Repository navigation
[beta-1.79] fix(toml): Don't warn on lints.rust.unexpected_cfgs.check-cfg - #13925
Merged
Merged
Conversation
While its unused, we thought we'd reduce warning noise for people using this key on nightly.
epage
marked this pull request as draft
May 17, 2024 17:40
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
Collaborator
|
rustbot
added
A-manifest
This is currently breaking CI because we run effectively `RUSTDOCFLAGS=-Dwarnings cargo +nightly doc`
epage
changed the title
This was referenced May 19, 2024
epage
marked this pull request as ready for review
May 21, 2024 14:31
Contributor
Author
|
The nightly failure is being tracked in rust-lang/rust#125319. As such, I'll workaround by updating dependencies. |
It looks like its checking nightly rustc links against cargo which is failing because of links related to check-cfg which is stable on nightly. See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Failures.20on.20Beta.20CI
rustbot
added
the
A-infrastructure
weihanglo
approved these changes
May 22, 2024
Member
|
@bors r+ Thanks for doing all the messy works. |
Contributor
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
[beta-1.79] Update cargo 2 commits in 8a7384119af18fa4b3311c310661acd81f1b4885..9ca20fadf04af535ec39d1e18c87cd886185d300 2024-05-03 01:19:24 +0000 to 2024-05-22 17:55:16 +0000 - [beta-1.79] upgrade gix from 0.62 to 0.63 (rust-lang/cargo#13950) - [beta-1.79] fix(toml): Don't warn on lints.rust.unexpected_cfgs.check-cfg (rust-lang/cargo#13925) r? ghost
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 25, 2024
…, r=Mark-Simulacrum Bump bootstrap compiler to the latest beta compiler This PR updates the bootstrap compiler, aka stage0 to the latest beta version, since it contains rust-lang/cargo#13925. It removes those unconditional Cargo warnings: ``` warning: [...]/rust/library/core/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg warning: [...]/rust/library/std/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg warning: [...]/rust/library/alloc/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg ``` for all contributors/users of this repository (including CI). I don't know if that's something we do, or if it's even advisable, feel free to close. r? `@Mark-Simulacrum`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2024
Rollup merge of rust-lang#125478 - Urgau:check-cfg-config-bump-stage0, r=Mark-Simulacrum Bump bootstrap compiler to the latest beta compiler This PR updates the bootstrap compiler, aka stage0 to the latest beta version, since it contains rust-lang/cargo#13925. It removes those unconditional Cargo warnings: ``` warning: [...]/rust/library/core/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg warning: [...]/rust/library/std/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg warning: [...]/rust/library/alloc/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg ``` for all contributors/users of this repository (including CI). I don't know if that's something we do, or if it's even advisable, feel free to close. r? `@Mark-Simulacrum`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta backports:
check-cfglint config for theunexpected_cfgslint #13913 (sort of): removes just the lint warning (in a different way to be minimal) so we reduce warning noise for people using this key on nightlyIn order to make CI pass, the following PRs are also cherry-picked:
timedue to Type inference regression onnightly-2024-05-20rust#125319)