Repository navigation
Improve help message for search_is_some lint - #12140
Merged
bors merged 2 commits intoJan 12, 2024
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Thank you! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Jan 20, 2024
…llogiq Improve wording for suggestion messages Follow-up of #12140. r? `@llogiq` changelog: Improve wording for suggestion messages
bors
added a commit
that referenced
this pull request
Jan 21, 2024
…llogiq Improve wording for suggestion messages Follow-up of #12140. r? `@llogiq` changelog: Improve wording for suggestion messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11681.
Like mentioned in the issue, we tend to use the formulation "consider using", which we didn't in this case. I think it clears both the confusion and also makes help message more coherent overall.
r? @llogiq
changelog: Improve help message for
search_is_somelint