Skip to content

x.py test ignores --no-fail-fast in some tool testsuites. #108261

Closed

Description

@jchecahi

It looks like some tool testsuites (like clippy's or rustfmt's) will ignore the no fail fast option. For example running ./x.py test --no-fail-fast clippy will stop after compile-test fails, something common in big endian platforms.

If I understand correctly this seems to be because bootstrap is not passing --no-fail-fast to cargo test in every tool implementation. Currently, the flag is passed in the Step trait implementation of some tools (i.e. cargo), right after calling tool::prepare_tool_cargo(). But others like mentioned clippy or rustfmt are missing it.

Activity

  1. jchecahi commented on Feb 20, 2023

    @jchecahi
    ContributorAuthor

    @rustbot claim

  2. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    C-bugCategory: This is a bug.
    on Feb 20, 2023
  3. jyn514 commented on Feb 20, 2023

    @jyn514
    Member
  4. added a commit that references this issue on Feb 22, 2023
    2f16355
  5. added a commit that references this issue on Feb 22, 2023
    8fd47a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions