Skip to content

issue-80074 test should not compile #119301

Closed

Description

@Mark-Simulacrum

The test in https://github.com/rust-lang/rust/blob/master/tests/ui/extern/issue-80074.rs shouldn't actually compile -- it's using a non-exported macro from a foreign crate. Instead, we should get an error indicating that the name is private and/or that the name doesn't exist at all.

Likely a regression introduced by #88019.

See discussion in https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/cross-crate.20macro.20usage.20allowed.20with.20no.20macro_export.3F

Activity

  1. added
    A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Dec 25, 2023
  2. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Dec 25, 2023
  3. added
    C-bugCategory: This is a bug.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Dec 26, 2023
  4. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Dec 26, 2023
  5. apiraino commented on Dec 26, 2023

    @apiraino
    Contributor

    WG-prioritization assigning priority (Zulip discussion).

    The question now is what happens if we revert/change this behaviour. What could the impact be (as an option, this could be discussed in a triage meeting)

    @rustbot label -I-prioritize +P-high

  6. added
    P-highHigh priority
    and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Dec 26, 2023
  7. bvanjoi commented on Dec 27, 2023

    @bvanjoi
    Contributor

    An interesting issue. I will attempt to resolve it.

    @rustbot claim

  8. added a commit that references this issue on Dec 28, 2023
    3832a95
  9. added 3 commits that reference this issue on Jan 22, 2024
    c1f9361
    0cf2281
    c5984ca
  10. added a commit that references this issue on Jan 22, 2024
    631b316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)C-bugCategory: This is a bug.P-highHigh priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-stablePerformance or correctness regression from one stable version to another.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions