Skip to content

LLVM 18 issue: tests/codegen/pow_of_two.rs broken after https://github.com/rust-lang/rust/commit/9dccd5dce11f2fcce81fc77f4271eaf2359e2626 #120377

New issue
New issue
Closed
#120376
Closed
LLVM 18 issue: tests/codegen/pow_of_two.rs broken after https://github.com/rust-lang/rust/commit/9dccd5dce11f2fcce81fc77f4271eaf2359e2626#120377
#120376
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.

Description

@krasimirgg
krasimirgg
opened on Jan 26, 2024

Seems like the updated test expectations don't quite match up with LLVM 18, first failing check is:

 // CHECK: %{{[^ ]+}} = zext i32 %exp to i64

Found over at our experimental rust + LLVM @ HEAD build bot:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/25504#018d4612-a220-458b-84c9-1d8f56b6fbde/724-725

Looks like LLVM 18 adds some extra nneg-s, testing a PR to fix this: #120380

Activity

  1. Imagekrasimirgg
    added
    C-bugCategory: This is a bug.
    on Jan 26, 2024
  2. Imagerustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jan 26, 2024

  3. krasimirgg commented on Jan 26, 2024

    @krasimirgg
    krasimirgg
    on Jan 26, 2024
    ContributorAuthor

    @rustbot label: +A-LLVM

  4. Imagerustbot
    added
    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
    on Jan 26, 2024
  5. Imagekrasimirgg
    added a commit that references this issue on Jan 26, 2024

    adapt tests/codegen/pow_of_two.rs for LLVM 18

    4c37367
  6. Imagecuviper
    linked a pull request that will close this issueUpdate codegen test for LLVM 18 #120376on Jan 26, 2024
  7. Imagesaethlin
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jan 27, 2024
  8. Imagebors
    closed this as completedin #120376on Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions