The compiler with debug assertions is really slow #121110

Activity

1. Noratrieb

   added

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   C-bugCategory: This is a bug.Category: This is a bug.

   A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to Rust

   on Feb 14, 2024
2. rustbot

   added

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Feb 14, 2024
3. Noratrieb

   changed the title [-]Compile with debug assertions is really slow[/-] [+]The compiler with debug assertions is really slow[/+] on Feb 14, 2024
4. Noratrieb

   removed

   needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triagingThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging

   on Feb 14, 2024
5. Noratrieb commented on Feb 14, 2024

   

   Noratrieb

   on Feb 14, 2024

   MemberAuthor

   More actions

   This is probably because of the recent changes to assert_unsafe_precondition. It contains a cfg(bootstrap) hack for debug_assertions() that's not inlined. Additionally, it outlines the predicate, which is super slow as well. Fixing the former is easy, fixing the latter is harder and requires adding #[inline(not_the_mir_inliner)].
6. bors

   added a commit that references this issue on Feb 14, 2024

   Auto merge of rust-lang#121114 - Nilstrieb:no-inline!, r=<try>

   ...

   90741d3
7. Noratrieb

   added 3 commits that reference this issue on Feb 20, 2024

   Rollup merge of rust-lang#121196 - Nilstrieb:the-clever-solution, r=s…

   ...

   This issue will close once commit 265ae67 is merged into the 'master' branch.

   265ae67

   Rollup merge of rust-lang#121196 - Nilstrieb:the-clever-solution, r=s…

   ...

   This issue will close once commit a3519ed is merged into the 'master' branch.

   a3519ed

   Rollup merge of rust-lang#121196 - Nilstrieb:the-clever-solution, r=s…

   ...

   This issue will close once commit 4ff6bb5 is merged into the 'master' branch.

   4ff6bb5
8. bors

   closed this as completedin 4ff6bb5on Feb 20, 2024
9. rust-timer

   added a commit that references this issue on Feb 20, 2024

   Unrolled build for rust-lang#121196

   ...

   This issue will close once commit a405cc6 is merged into the 'master' branch.

   a405cc6
10. Noratrieb commented on Feb 20, 2024

    

    Noratrieb

    on Feb 20, 2024

    MemberAuthor

    More actions

    turns out this was caused by many different factors compounding in an unfortunate way :D
    oli's intrinsic changes outlining some important functions, and the unsafe preconditions being quite bad for runtime performance
11. bors

    added 2 commits that reference this issue on Feb 22, 2024

    Auto merge of rust-lang#121114 - Nilstrieb:no-inline!, r=<try>

    ...

    4ba1a99

    Auto merge of rust-lang#121114 - Nilstrieb:no-inline!, r=saethlin

    ...

    e9f9594