Skip to content

[LoongArch] dead loop after nightly-2024-02-12 #121289

New issue
New issue
Closed
#121291
Closed
[LoongArch] dead loop after nightly-2024-02-12#121289
#121291
Labels
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-bugCategory: This is a bug.I-hangIssue: The compiler never terminates, due to infinite loops, deadlock, livelock, etc.O-loongarchTarget: LoongArch (LA32R, LA32S, LA64)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@heiher
heiher
opened on Feb 19, 2024

I tried this code:

rustc -vV
cargo -vV

I expected to see this happen: outputs version info

Instead, this happened: dead loop in main entry function.

Meta

rustc --version --verbose:

a84bb95a1 2024-02-13

b381d3ab2 2024-02-12 good
a84bb95a1 2024-02-13 bad

Activity

  1. Imageheiher
    added
    C-bugCategory: This is a bug.
    on Feb 19, 2024
  2. Imagerustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 19, 2024
  3. Imageheiher
    changed the title [-][Loongarch] dead loop after nightly-2024-02-12[/-] [+][LoongArch] dead loop after nightly-2024-02-12[/+] on Feb 19, 2024

  4. heiher commented on Feb 19, 2024

    @heiher
    heiher
    on Feb 19, 2024
    ContributorAuthor

    @rustbot label O-loongarch

  5. Imagerustbot
    added
    O-loongarchTarget: LoongArch (LA32R, LA32S, LA64)
    on Feb 19, 2024
  6. Imagejieyouxu
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    I-hangIssue: The compiler never terminates, due to infinite loops, deadlock, livelock, etc.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 19, 2024
  7. Imagenikic
    added
    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
    on Feb 19, 2024

  8. nikic commented on Feb 19, 2024

    @nikic
    nikic
    on Feb 19, 2024
    Contributor

    That would be due to the LLVM 18 upgrade.

  9. heiher commented on Feb 19, 2024

    @heiher
    heiher
    on Feb 19, 2024
    ContributorAuthor

    That would be due to the LLVM 18 upgrade.

    Yeah. It seems that the CI loongarch64-unknown-linux-gnu ld does not handle R_LARCH_CALL36 (pcaddu18+jirl) relocations correctly.

    0000000000000a40 <main>:                           
   a40:   02ffc063    addi.d          $sp, $sp, -16  
   a44:   29c02061    st.d            $ra, $sp, 8    
   a48:   001500a6    move            $a2, $a1       
   a4c:   02800085    addi.w          $a1, $a0, 0    
   a50:   1a000024    pcalau12i       $a0, 1         
   a54:   02e88084    addi.d          $a0, $a0, -1504
   a58:   03800c07    li.w            $a3, 0x3       
>  a5c:   1e000001    pcaddu18i       $ra, 0         # loop
>  a60:   4c000021    jirl            $ra, $ra, 0    
   a64:   28c02061    ld.d            $ra, $sp, 8    
   a68:   02c04063    addi.d          $sp, $sp, 16   
   a6c:   4c000020    ret

  10. heiher commented on Feb 19, 2024

    @heiher
    heiher
    on Feb 19, 2024
    ContributorAuthor

    There is no version of crosstool-ng that supports R_LARCH_CALL36, I'll revert the medium code model until the issue is resolved.

  11. xry111 commented on Feb 19, 2024

    @xry111
    xry111
    on Feb 19, 2024
    Contributor

    Oooops. Is this communicated with crosstool-ng maintainers?

  12. xry111 commented on Feb 19, 2024

    @xry111
    xry111
    on Feb 19, 2024
    Contributor

    But maybe crosstool-ng maintainers can't act as well due to the incompatibility between GCC 13.2 and Binutils 2.42 (loongson-community/discussions#41) :(. I'm not sure how to fix such an incompatibility...

  13. heiher commented on Feb 19, 2024

    @heiher
    heiher
    on Feb 19, 2024
    ContributorAuthor

    Oooops. Is this communicated with crosstool-ng maintainers?

    Not yet. binutils 2.42 in progress: crosstool-ng/crosstool-ng#2095

  14. 1 remaining item

  15. ImageNoratrieb
    added 2 commits that reference this issue on Feb 20, 2024

    Rollup merge of rust-lang#121291 - heiher:revert-medium-cmodel, r=Nil…

    71ed0b9

    Rollup merge of rust-lang#121291 - heiher:revert-medium-cmodel, r=Nil…

    5540d81
  16. Imagebors
    closed this as completedin 9c32a7don Feb 20, 2024
  17. Imagerust-timer
    added a commit that references this issue on Feb 20, 2024

    Unrolled build for rust-lang#121291

    6db8721
  18. Imageheiher
    added a commit that references this issue on Aug 13, 2024

    Update `crosstool-ng` for loongarch64

    cebae30
  19. Imagebors
    added a commit that references this issue on Aug 14, 2024

    Auto merge of rust-lang#129048 - heiher:update-crosstool-loongarch64,…

    19d9ce7
  20. Imagetgross35
    added a commit that references this issue on Aug 19, 2024

    Rollup merge of rust-lang#129048 - heiher:update-crosstool-loongarch6…

    582b0a6
  21. Imagerust-timer
    added a commit that references this issue on Aug 19, 2024

    Unrolled build for rust-lang#129048

    f9f3f06
  22. Imagegithub-actions
    added a commit that references this issue on Aug 20, 2024

    Rollup merge of #129048 - heiher:update-crosstool-loongarch64, r=Mark…

    ed1c0ac

  23. xen0n commented on Sep 6, 2024

    @xen0n
    xen0n
    on Sep 6, 2024
    Contributor

    #129048 is merged recently that bumped the LoongArch binutils to 2.42, so can we try #120661 again?

  24. heiher commented on Sep 6, 2024

    @heiher
    heiher
    on Sep 6, 2024
    ContributorAuthor

    #129048 is merged recently that bumped the LoongArch binutils to 2.42, so can we try #120661 again?

    Yes, with #129048 merged, we can retry #120661.

  25. Imagematthiaskrgr
    added a commit that references this issue on Sep 13, 2024

    Rollup merge of rust-lang#130266 - heiher:loong-medium-cmodel, r=comp…

    778f6fb
  26. Imagerust-timer
    added a commit that references this issue on Sep 13, 2024

    Unrolled build for rust-lang#130266

    c8ccedf
  27. Imagegithub-actions
    added a commit that references this issue on Sep 14, 2024

    Rollup merge of #130266 - heiher:loong-medium-cmodel, r=compiler-errors

    c48577c

  28. xen0n commented on Sep 14, 2024

    @xen0n
    xen0n
    on Sep 14, 2024
    Contributor

    Today's nightly is built off of #130312, which contains #130266 and does work:

    $ rustc -Vv
rustc 1.83.0-nightly (0609062a9 2024-09-13)
binary: rustc
commit-hash: 0609062a91c8f445c3e9a0de57e402f9b1b8b0a7
commit-date: 2024-09-13
host: loongarch64-unknown-linux-gnu
release: 1.83.0-nightly
LLVM version: 19.1.0

    And the medium code model is indeed in use:

    $ readelf -r ~/.rustup/toolchains/nightly-loongarch64-unknown-linux-gnu/lib/rustlib/loongarch64-unknown-linux-gnu/lib/libcore-c292f7f95e655c4c.rlib | grep 'R_LARCH_CALL36' | wc -l
769

    So this issue is finally resolved. Thanks for everyone involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.C-bugCategory: This is a bug.I-hangIssue: The compiler never terminates, due to infinite loops, deadlock, livelock, etc.O-loongarchTarget: LoongArch (LA32R, LA32S, LA64)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions