Repository navigation
thread_local with const { } fails to compile in file with #![forbid(unsafe_op_in_unsafe_fn)] #121483
Description
#![forbid(unsafe_op_in_unsafe_fn)]
use std::cell::Cell;
thread_local! {
pub static FOO: Cell<u32> = const { Cell::new(1) };
}I expected to see this happen: Compiles without error.
Instead, this happened: Fails to build with this error:
error[E0453]: deny(unsafe_op_in_unsafe_fn) incompatible with previous forbid
--> src/lib.rs:5:1
|
1 | #![forbid(unsafe_op_in_unsafe_fn)]
| ---------------------- `forbid` level set here
...
5 | / thread_local! {
6 | | pub static FOO: Cell<u32> = const { Cell::new(1) };
7 | | }
| |_^ overruled by previous forbid
|
= note: this error originates in the macro `$crate::thread::local_impl::thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)
For more information about this error, try `rustc --explain E0453`.
It seems https://github.com/rust-lang/rust/blob/master/library/std/src/sys/pal/common/thread_local/os_local.rs is using #[deny(unsafe_op_in_unsafe_fn)]. But the existence of forbid makes somewhat problematic in a macro.
Meta
Occurs on rustc 1.76.0 (07dca489a 2024-02-04) and rustc 1.78.0-nightly (3406ada96 2024-02-21).
Activity
ZeWaka commentedon Apr 12, 2024
Yeah, this isn't playing nice with the
thread_local_initializer_can_be_made_constclippy lint.Rollup merge of rust-lang#121560 - Noratrieb:stop-lint-macro-nonsense…
Unrolled build for rust-lang#121560