You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tracking Issue for mixed_integer_ops_unsigned_sub #126043
I'm not a huge fan of overflowing_* methods but I think it's fine in this case since it is consistent with the existing ones. The other methods seem fine to me.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
Activity
Rollup merge of rust-lang#126046 - davidzeng0:mixed_integer_ops_unsig…
Unrolled build for rust-lang#126046
nxsaken commentedon May 29, 2025
Discovered this through the unstable
checked_sub_signed. Looks like the impl (#126046) was merged last year. What's needed to stabilize this?rustbot commentedon Jun 3, 2025
Error: Only Rust team members can ping teams.
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.
callmeclover commentedon Jun 5, 2025
@Amanieu @rust-lang/libs Can we start FCP on this? The ACP (rust-lang/libs-team#386) and implementation (#126046) passed last year.
Amanieu commentedon Jun 9, 2025
I'm not a huge fan of
overflowing_*methods but I think it's fine in this case since it is consistent with the existing ones. The other methods seem fine to me.@rfcbot merge
rfcbot commentedon Jun 9, 2025
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
rfcbot commentedon Jun 10, 2025
🔔 This is now entering its final comment period, as per the review above. 🔔
3 remaining items
Rollup merge of rust-lang#143236 - nxsaken:mixed_integer_ops_unsigned…
Unrolled build for #143236
Rollup merge of #143236 - nxsaken:mixed_integer_ops_unsigned_sub, r=i…
Rollup merge of rust-lang#143236 - nxsaken:mixed_integer_ops_unsigned…
rust190: add a package for rust 1.90.0.
build(deps): update rust to v1.90.0
lang/rust: update to version 1.90.0 from pkgsrc-wip.
lang/rust: update to version 1.90.0 from pkgsrc-wip.
lang/rust: update to version 1.90.0 from pkgsrc-wip.
lang/rust: update to version 1.90.0 from pkgsrc-wip.
lang/rust: update to version 1.90.0 from pkgsrc-wip.
lang/rust: update to version 1.90.0 from pkgsrc-wip.