Repository navigation
Bad replacement for unsafe extern block suggestion #126756
Description
The span for the suggestion to add an unsafe qualifier to an extern block ends up deleting the entire extern token.
#![feature(unsafe_extern_blocks)]
extern "C" {
unsafe fn foo();
}Generates this output:
error: items in unadorned `extern` blocks cannot have safety qualifiers
--> src/main.rs:4:5
|
3 | extern "C" {
| ---------- help: add unsafe to this `extern` block
4 | unsafe fn foo();
| ^^^^^^^^^^^^^^^^
When the suggestion is applied, the code results in:
#![feature(unsafe_extern_blocks)]
{
unsafe fn foo();
}Although the suggestion is currently marked MaybeIncorrect, I think it should still provide something that is closer to being correct than to delete it. It also seems like this should be a relatively simple replacement that should support MachineApplicable. Ref:
rust/compiler/rustc_ast_passes/src/errors.rs
Lines 224 to 225 in 1ca578e
I expected to see this happen: Suggestion adds the unsafe keyword to the front of extern
Instead, this happened: Deletes the extern
Meta
rustc 1.81.0-nightly (59e2c01c2 2024-06-17)
binary: rustc
commit-hash: 59e2c01c2217a01546222e4d9ff4e6695ee8a1db
commit-date: 2024-06-17
host: aarch64-apple-darwin
release: 1.81.0-nightly
LLVM version: 18.1.7
Tracking:
Activity
traviscross commentedon Jun 25, 2024
cc @spastorino
spastorino commentedon Jun 25, 2024
@chenyukang if you want to take this one, go ahead. Also assigned myself for tracking purposes but I can fix this easily too.
chenyukang commentedon Jun 26, 2024
sorry for the delay, submitted a PR #126973.
Rollup merge of rust-lang#126973 - chenyukang:yukang-fix-126756-unsaf…
Rollup merge of rust-lang#126973 - chenyukang:yukang-fix-126756-unsaf…
Unrolled build for rust-lang#126973
Rollup merge of rust-lang#127921 - spastorino:stabilize-unsafe-extern…
Rollup merge of rust-lang#127921 - spastorino:stabilize-unsafe-extern…
Unrolled build for rust-lang#127921