Skip to content

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs #129163

Closed

Description

@tgross35

This file is only f32 and f64: https://github.com/rust-lang/rust/blob/a73bc4a131d94eba633c4c572a28e0bf94a67530/tests/ui/consts/const-float-bits-conv.rs, but we should add the other float types to this test.

The change should wait for #128598 since that changes some of these semantics (this PR is almost merged).

There are probably a handful of tests that only check f32 and f64 but could use updates with the new types.

Activity

  1. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Aug 16, 2024
  2. added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Aug 16, 2024
  3. rezwanahmedsami commented on Aug 17, 2024

    @rezwanahmedsami
    Contributor

    Okay will do that

  4. tgross35 commented on Aug 17, 2024

    @tgross35
    MemberAuthor

    FYI you can comment @rustbot claim to assign yourself an issue

  5. rezwanahmedsami commented on Aug 17, 2024

    @rezwanahmedsami
    Contributor

    @rustbot claim

  6. added a commit that references this issue on Aug 17, 2024
    b657787
  7. added a commit that references this issue on Aug 18, 2024
    28f80c7
  8. added 2 commits that reference this issue on Aug 20, 2024
    cf5dcd2
    acc9752
  9. added a commit that references this issue on Aug 21, 2024
    61cc570
  10. added a commit that references this issue on Aug 22, 2024
    b79cc36
  11. added 2 commits that reference this issue on Aug 22, 2024
    d3d65dc
    42e8972
  12. added 2 commits that reference this issue on Aug 23, 2024
    b07a988
    5438d97
  13. added a commit that references this issue on Aug 25, 2024
    520ed56
  14. added a commit that references this issue on Aug 26, 2024
    dedfb35
  15. added a commit that references this issue on Aug 26, 2024
    011e2d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions