Repository navigation
Tracking Issue for const_make_ascii #130698
Description
Feature gate: #![feature(const_make_ascii)]
This is a tracking issue for marking the make_ascii_uppercase and make_ascii_lowercase methods in char, u8, [u8], and str as "const."
Public API
impl char {
pub const fn make_ascii_uppercase(&mut self);
pub const fn make_ascii_lowercase(&mut self);
}
impl u8 {
pub const fn make_ascii_uppercase(&mut self);
pub const fn make_ascii_lowercase(&mut self);
}
impl [u8] {
pub const fn make_ascii_uppercase(&mut self);
pub const fn make_ascii_lowercase(&mut self);
}
impl str {
pub const fn make_ascii_uppercase(&mut self);
pub const fn make_ascii_lowercase(&mut self);
}Steps / History
- Implementation for
char: Markchar::make_ascii_uppercaseandchar::make_ascii_lowercaseas const. #130697 - Implementation for
u8: Marku8::make_ascii_uppercaseandu8::make_ascii_lowercaseas const. #130713 - Implementation for
[u8]andstr: Markmake_ascii_uppercaseandmake_ascii_lowercasein[u8]andstras const. #130738 - Final comment period (FCP)
- Stabilization PR: Stabilise
const_make_ascii. #131496
Unresolved Questions
- None yet.
Activity
dtolnay commentedon Sep 22, 2024
@rust-lang/libs-api:
@rfcbot fcp merge
to_ascii_uppercase/to_ascii_lowercasehave been stable in const since 1.52.make_ascii_uppercase/make_ascii_lowercaseare unblocked now by the stabilization of #57349.rfcbot commentedon Sep 22, 2024
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
Auto merge of rust-lang#130697 - bjoernager:const-char-make-ascii, r=…
okaneco commentedon Sep 22, 2024
Can the
u8methods be included in this?https://doc.rust-lang.org/stable/std/primitive.u8.html#method.make_ascii_lowercase
https://doc.rust-lang.org/stable/std/primitive.u8.html#method.make_ascii_uppercase
Similarly const stable
u8::to_ascii_uppercase/u8::to_ascii_lowercasesince 1.52.bjoernager commentedon Sep 22, 2024
Yes, that sounds like a good idea. I'll try adding another PR later.
[-]Tracking Issue for `const_char_make_ascii`[/-][+]Tracking Issue for `const_make_ascii`[/+]Rollup merge of rust-lang#130713 - bjoernager:const-char-make-ascii, …
Rollup merge of rust-lang#130713 - bjoernager:const-char-make-ascii, …
Rollup merge of rust-lang#130713 - bjoernager:const-char-make-ascii, …
Unrolled build for rust-lang#130713
Auto merge of rust-lang#130738 - bjoernager:const-make-ascii, r=jhpratt
rfcbot commentedon Oct 1, 2024
🔔 This is now entering its final comment period, as per the review above. 🔔
bjoernager commentedon Oct 11, 2024
#131496 stabilises this.
rfcbot commentedon Oct 11, 2024
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
Rollup merge of rust-lang#131496 - bjoernager:const-make-ascii, r=dto…
Rollup merge of rust-lang#131496 - bjoernager:const-make-ascii, r=dto…
Unrolled build for rust-lang#131496