Repository navigation
Tracking Issue for non_null_from_ref #130823
Description
Feature gate: #![feature(non_null_from_ref)]
This is a tracking issue for adding the convenience constructors from_ref and from_mut to core::ptr::NonNull.
Public API
// core::ptr
impl<T: ?Sized> NonNull<T> {
pub const fn from_ref(r: &T) -> Self;
pub const fn from_mut(r: &mut T) -> Self;
}Steps / History
- API change proposal (ACP): #448
- Implementation: Add
from_refandfrom_mutconstructors tocore::ptr::NonNull. #130822 - Final comment period (FCP)
- Stabilization PR: Stabilize
#![feature(non_null_from_ref)]#140511
Unresolved Questions
- None yet.
Reacted by orzogc, zachs18, Colin Cai, Diego Augusto, Nazar Mokrynskyi, zopsicle, Vilim Lendvaj, Trevor Gross, Karolis Stasaitis, Mads Marquart and 2 more
Activity
Rollup merge of rust-lang#130822 - bjoernager:non-null-from-ref, r=dt…
Unrolled build for rust-lang#130822
smalis-msft commentedon Jan 30, 2025
Is there anything blocking these from stabilization? They seem pretty straightforward.
bjoernager commentedon Jan 30, 2025
Nope, nothing that I'm aware of (other than the FCP).
m-ou-se commentedon Feb 19, 2025
@rfcbot merge
rfcbot commentedon Feb 19, 2025
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
mathisbot commentedon Apr 30, 2025
mathisbot commentedon Apr 30, 2025
Stabilization PR: #140511
rfcbot commentedon May 6, 2025
🔔 This is now entering its final comment period, as per the review above. 🔔
rfcbot commentedon May 16, 2025
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
Rollup merge of rust-lang#140511 - mathisbot:master, r=dtolnay
Unrolled build for rust-lang#140511
Rollup merge of #140511 - mathisbot:master, r=dtolnay
Rollup merge of rust-lang#140511 - mathisbot:master, r=dtolnay
tgross35 commentedon Jun 9, 2025
Stabilized in #140511
fix: add temporary patch for score_baselibs_rust
fix: add temporary patch for score_baselibs_rust
fix: add temporary patch for score_baselibs_rust