Skip to content

typos-cli installed by bootstrap is slow #147331

New issue
New issue
Closed
#147332
Closed
typos-cli installed by bootstrap is slow#147331
#147332
Assignees
Shunpoco
Labels
C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@Shunpoco
Shunpoco
opened on Oct 4, 2025

Summary

Discussion: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20Spellcheck.20check.20all.20files.3F/with/542621944

typos-cli installed by bootstrap for spellcheck is really slow.
I found that bootstrap adds -Copt-lvel=0 option for installing the tool. It affects the performance.

Command used

./x test tidy --extra-checks=spellcheck

Expected behaviour

Spellcheck in the tidy test finishes in some seconds

Actual behaviour

Spellcheck takes 10~ seconds

Operating system

Ubuntu 24.04

HEAD

595b9a4

Additional context

We've discussed that on CI we'd like to set the opt-level (0 or 1), but on local dev env we'd like to install the tool without the option.

Activity

  1. ImageShunpoco
    added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    C-bugCategory: This is a bug.
    on Oct 4, 2025
  2. Imagerustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Oct 4, 2025

  3. Shunpoco commented on Oct 4, 2025

    @Shunpoco
    Shunpoco
    on Oct 4, 2025
    ContributorAuthor

    @rustbot claim

  4. Imagerustbot
    assigned
    Shunpoco
    on Oct 4, 2025
  5. Imagesaethlin
    removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Oct 4, 2025
  6. Imageworkingjubilee
    added a commit that references this issue on Oct 5, 2025

    Rollup merge of rust-lang#147332 - Shunpoco:fast-spellcheck, r=Kobzol

    23d1cc7
  7. Imagebors
    closed this as completedin 23d1cc7on Oct 5, 2025
  8. Imagerust-timer
    added a commit that references this issue on Oct 5, 2025

    Unrolled build for #147332

    4caeb4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions