Repository navigation
Generalize the few functions that are not common across all the core integer modules #2239
Description
The uint/int/i8 etc modules mostly share the same code but there are a few functions that are still specific to a single module. It should be possible to move these to the int-template or uint-template module as appropriate so they can be used for all integer types.
These are they:
- int::{ hash, parse_buf, from_str, to_str, str, pow }
- uint::{ div_ceil, div_round, div_floor, hash, iterate }
- uint::{ next_power_of_two, parse_buf, from_str, to_str, str }
- u64::{ to_str, str, from_str }
Activity
core: Generalize uint-string conversions to all uint types
core: Generalize int-string conversions to all int types
graydon commentedon Aug 8, 2012
This feels nearly-done to me, you agree?
Aatch commentedon Jun 7, 2013
Is this done now? With the extensive re-working of
std::numwe don't even have[u]int-templateany more.thestinger commentedon Aug 5, 2013
Instead of the template we have macros generating non-generic functions now.
thestinger commentedon Aug 20, 2013
There's no longer a lack of code reuse, but definitely a lack of generic functions rather than generated code. These are often very hard to write without missing corner cases, so they can be tackled individually.
Auto merge of rust-lang#2239 - RalfJung:rustup, r=RalfJung
Merge pull request rust-lang#2239 from Kobzol/ci-fix-2