The crate store does not deduplicate used crates #3474

Activity

1. pnkfelix commented on Jun 24, 2013

   

   pnkfelix

   on Jun 24, 2013

   Contributor

   More actions

   Bug triage 2013jun24. I tried to construct an example where linking to the same crate multiple times would cause the types to not resolve, but I did not encounter any examples of such. Still, it would be good to fix this bug.
2. huonw commented on Dec 19, 2013

   

   huonw

   on Dec 19, 2013

   Contributor

   More actions

   Triage: I think this may be fixed.

   #[no_uv];
   
   #[cfg(extra_crate)]
   extern mod std;
   
   fn main() {}

   $ RUST_LOG=rustc::metadata::creader rustc --cfg extra_crate 3474.rs
   resolving extern mod stmt. ident: @"std" path_opt: None
   resolving deps of external crate
   resolved crates:
   cnum: 1u32
   span: syntax::codemap::Span{lo: syntax::codemap::BytePos(0u32), hi: syntax::codemap::BytePos(0u32), expn_info: None}
   hash: @"04ff901ef9eb93b7ed8d17b7ddf76fa8eb8b4c7295ad21af7133790d77381330"
   

   and the output is the same without --cfg extra_crate. The above is full dump of the crate_cache list, clearly std doesn't appear twice (Without the no_uv there are two, rustuv and std).
3. huonw

   closed this as completedon Dec 19, 2013
4. RalfJung

   added a commit that references this issue on May 11, 2024

   Auto merge of rust-lang#3474 - tyilo:wcslen, r=RalfJung

   ...

   3d269e9
5. U007D

   added a commit that references this issue on Aug 21, 2026

   Merge rust-lang#3474

   ...

   af50e4f