Skip to content

Licensing issue #36556

Closed
Closed

Description

@pmarcelll

The files src/libstd/sync/mpsc/spsc_queue.rs and src/libstd/sync/mpsc/spsc_queue.rs was originally added a long time ago in #10080, and the first line is Copyright (c) 2010-2011 Dmitry Vyukov. All rights reserved. (explained in #9710). These files are only licensed under the BSD 2-Clause license.

  • The file doesn't contain the usual Copyright The Rust Developers, although the team is a co-author.
  • Does the second clause means, that rustc should print the whole BSD license just for these? (Or I'm misinterpreting it?)

Is it an issue at all? (I'm not that familiar with distributing and licensing software.) If it is, can we do something about it?

Activity

  1. Mark-Simulacrum commented on May 13, 2017

    @Mark-Simulacrum
    Member

    cc @brson because this is a licensing question

  2. aturon commented on May 17, 2017

    @aturon
    Contributor

    cc @rust-lang/core

  3. alexcrichton commented on May 17, 2017

    @alexcrichton
    Member

    I believe we just need to add this to the COPYRIGHT file in the root of the repository, and that should do the trick! (this is similar to jemalloc)

  4. pmarcelll commented on May 17, 2017

    @pmarcelll
    ContributorAuthor

    Thanks for looking into this issue!
    The code comes from #9710, from the first comment:

    I included the license Dmitry asked me to use when I implemented a C++11 version of this queue a while ago. If the license is an issue, I suggest reaching out to Dmitry.

    So I guess it's worth asking him, he's active on Github.

    @dvyukov with all due respect, can you help us resolve this issue? The real issue is that the code in question has a different license than the rest of the codebase (although the Apache2/MIT dual license is very similar to the BSD license).

  5. added a commit that references this issue on May 22, 2017
    0b85b64
  6. brson commented on May 22, 2017

    @brson
    Contributor

    I think it is not a problem that these files are BSD licensed - rust carries a bunch of licenses, including BSD, but it wouldn't hurt to relicense them.

    Well, actually, if this is the only BSD code in std (I don't know if that's the case), then removing the BSD license would reduce the burden on those redistributing std.

  7. added 6 commits that reference this issue on May 23, 2017
    7e4dda1
    a01f363
    7e1cbc7
    a103816
    6f84931
    73d4b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-libs-api[DEPRECATED; DO NOT USE]

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions