Skip to content

librustdoc no longer part of distributable #43729

Closed

Description

@nrc

librustdoc used to be distributed with other compiler crates and could be found in the sysroot. This is no longer the case which breaks any crate which does extern crate rustdoc;.

I assume this wasn't intentional and is due to the changes with how rustdoc is being built.

cc @Mark-Simulacrum @alexcrichton

Activity

  1. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    on Aug 8, 2017
  2. alexcrichton commented on Aug 8, 2017

    @alexcrichton
    Member

    Hm this was indeed intentional, all due to #43482. That being said, it wasn't intended to break things!

    @nrc did you have tools using extern crate rustdoc out of tree? That's sort of something I'd hope that we wouldn't have to keep working :(

  3. Mark-Simulacrum commented on Aug 8, 2017

    @Mark-Simulacrum
    Member

    Yes, this was indeed intentional. We can technically fix this I think if we need to, but I'd prefer not to -- it'd be a bit of a hack.

  4. nrc commented on Aug 8, 2017

    @nrc
    MemberAuthor

    did you have tools using extern crate rustdoc out of tree?

    Yes, rustw does. It only uses its markdown rendering though. I'd assume I could pull that into an external crate, but iirc, the last time I tried that it was tied into rustdoc and compiler internals in weird ways.

    I'll look into that - I assume Steve will have to solve a similar problem for new rustdoc, so maybe I can use that?

  5. Mark-Simulacrum commented on Aug 9, 2017

    @Mark-Simulacrum
    Member

    Well, if it's not working out to migrate to either the new rustdoc or otherwise solve the problem, let us know and we can discuss making librustdoc remain in the sysroot.

  6. removed
    T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.
    on Sep 15, 2017
  7. Mark-Simulacrum commented on Sep 15, 2017

    @Mark-Simulacrum
    Member

    @rfcbot fcp close

    Let's see if this works...

    If not, I'll just close; I don't think this is going to change. rustdoc is unstable, and shouldn't really be used for markdown rendering anyway...

  8. rfcbot commented on Sep 15, 2017

    @rfcbot

    Team member @Mark-Simulacrum has proposed to close this. The next step is review by the rest of the tagged teams:

    No concerns currently listed.

    Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  9. added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Sep 15, 2017
  10. steveklabnik commented on Sep 15, 2017

    @steveklabnik
    Contributor

    I assume Steve will have to solve a similar problem for new rustdoc

    I was planning on publishing on crates.io, honestly.

  11. rfcbot commented on Feb 16, 2018

    @rfcbot

    🔔 This is now entering its final comment period, as per the review above. 🔔

  12. added
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    and removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Feb 16, 2018
  13. rfcbot commented on Feb 26, 2018

    @rfcbot

    The final comment period is now complete.

  14. added
    disposition-closeThis PR / issue is in PFCP or FCP with a disposition to close it.
    and removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on May 24, 2018
  15. Mark-Simulacrum commented on Jun 12, 2018

    @Mark-Simulacrum
    Member

    Closing as per concluded FCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.disposition-closeThis PR / issue is in PFCP or FCP with a disposition to close it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions